-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight equal addresses #10
Comments
Hi, can I take this? This is my 4th OD Hack. |
Hello, Can I work on this |
@saimeunt hello sir. I'm Gerson, you can check my OD profile here: https://app.onlydust.com/u/Gerson2102 |
Hi, can I take this? |
Hello Project Lead! I'm Ugo, a fullstack Dev (js,React,Node,Next.js,Three.js) developer with a strong track record in OD hack projects. I've been actively involved since Edition 2, contributing to various initiatives, and I'm thrilled to be part of Edition 5! Here's how I plan to approach the issue:
|
Hi, @saimeunt I will be glad to contribute to the Highlight Equal Addresses feature for Op Scan. This is my first time contributing to a Walnut project as I didn't get the opportunity to work on any frontend tasks during ODHack 4.0. With my 3 years of expertise in Next.js, TypeScript, Shadcn, and React, I’m confident I can deliver a robust and user-friendly page. You can check out my Github here: https://github.com/Benjtalkshow. Here is my implementation Approach:I will use tailwindcss and JavaScript to highlight addresses on hover with a yellow-ish (#FFFFCC) background. I'll ensure compatibility and responsiveness using React and Shadcn. User Benefits:I'll enhance user navigation by visually distinguishing relevant addresses within transactions. I'll maintain interface consistency akin to industry standards such as Etherscan. Validation and Integration:I'll conduct thorough testing across browsers and devices to ensure consistent functionality. |
Hello, I'm Mariàngela, and I bring extensive experience in frontend development. https://github.com/MariangelaNM |
Hello Walnut Fam, I am a seasoned fullstack developer with a focus on front-end development. Although I haven't contributed to Walnut before, I am excited by your welcoming stance: "However, if you are new, don’t worry—we are eager to attract new talent..." I am passionate about creating responsive, modular, and scalable UI components and would love to take on this issue. Here are my profiles for your reference:
Best regards, |
Hello @saimeunt, I'm a Full Stack Web Developer with a solid background in front-end and back-end development. I am searching my first issue in the OD hack. So it will be a pleasure to contribute for the first time to this great project. References:I was reviewing the repository to see what the issue was, and I made an approximation and solved it. So here are the changes made:
With this setup, if we need to display transactions elsewhere, there's no need to rewrite the code.
Now, latest-transactions.tsx and latest-transaction.tsx, as well as latest-l1-l2-transactions.tsx and latest-l1-l2-transaction.tsx, are properly separated.
I used a LatestTransactionsProps interface to pass these props in a structured way to the child component. In the child component, I compare hoveredAddress with the transaction address, and if they match, I apply the text-yellow-200 class to highlight the address. This implementation ensures that matching addresses are properly highlighted when hovering over them on the transaction details page. This applies to both the Latest L1→L2 Transactions and Latest Transactions sections. By the way, I already have the branch. |
@JoelVR17 I like your approach as it's the closest to the React way of doing things, however you will need to refactor it a little bit to be sustainable in the long run. |
Thanks a lot @saimeunt, I already did the PR. |
Highlight equal addresses
Read contributors guidelines
On a Transaction detail page, when a user hovers over an address, the address should get highlighted in a yellow-ish color, similar to Etherscan.
Other addresses on this page that are equal to the address being hovered, should also be highlighted.
This will help the user to easily see equal addresses when exploring the transaction detail page.
The text was updated successfully, but these errors were encountered: