Hide all symbols in llvm namespace (pytorch#63272)

bertmaher · facebook-github-bot · commit 0ce4d30c4466 · 2021-08-15T11:29:43.000-07:00
Summary: Pull Request resolved: pytorch#63272 Test Plan: Imported from OSS Reviewed By: nikithamalgifb Differential Revision: D30331695 Pulled By: bertmaher fbshipit-source-id: d35130c96f7e2a31fa86d9d80de59002e96301df
diff --git a/caffe2/CMakeLists.txt b/caffe2/CMakeLists.txt
@@ -815,7 +815,7 @@ if(USE_LLVM AND LLVM_FOUND)
   elseif(UNIX)
     set(LINKER_SCRIPT "${CMAKE_CURRENT_SOURCE_DIR}/version_script.lds")
     set_target_properties(torch_cpu PROPERTIES LINK_DEPENDS ${LINKER_SCRIPT})
-    set_target_properties(torch_cpu PROPERTIES LINK_FLAGS "-Wl,--version-script=${LINKER_SCRIPT}")
+    target_link_libraries(torch_cpu PRIVATE "-Wl,--version-script=${LINKER_SCRIPT}")
   endif()
 endif(USE_LLVM AND LLVM_FOUND)
 
diff --git a/caffe2/unexported_symbols.lds b/caffe2/unexported_symbols.lds
@@ -1,2 +1 @@
-__ZN4llvm*
-__ZNK4llvm*
+*4llvm*
diff --git a/caffe2/version_script.lds b/caffe2/version_script.lds
@@ -1,7 +1,4 @@
 pytorch {
-  global:
-    *;
   local:
-    _ZN4llvm*;
-    _ZNK4llvm*;
+    *4llvm*;
 };

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1 @@`
`1`		`-__ZN4llvm*`
`2`		`-__ZNK4llvm*`
	`1`	`+4llvm`