Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrows signs are not active after a server restart #239

Open
carlrobert opened this issue Apr 24, 2015 · 3 comments
Open

arrows signs are not active after a server restart #239

carlrobert opened this issue Apr 24, 2015 · 3 comments
Assignees
Milestone

Comments

@carlrobert
Copy link
Contributor

  1. Create a sign.

  2. Look at it and do arrows.sign()

  3. Click the sign and try shooting an arrow. Works as expected.

  4. Stop the server.

  5. Restart the server. Error message:
    [20:12:35] [ScriptCraft] [ERROR]: Plugin C:/Local Data/rs/CanaryMod/scriptcraft/
    plugins/arrows.js Error: Error executing module C:/Local Data/rs/CanaryMod/scrip
    tcraft/plugins/arrows.js line Consider Minetest #195 : Cannot get property "constructor" of null
    undefined

    undefined

  6. In the prompt, /js arrows does not tab complete since the arrows module is not loaded.

signs-store.json quoted below as per step 4.

{
"menus": {
"Arrow": [
null,
null
],
"Dinner": [],
"Time": []
}
}

CanaryMod 1.2.0, ScriptCraft 3.1.3. Reproducible on different Windows installations.

@carlrobert
Copy link
Contributor Author

After fixing the "constructor" spelling (#232), there is no error message and arrows loads as expected. However, after a restart, the sign is not an arrows sign any more. So, right now the failing test case is as follows:

  1. Create a sign.
  2. Look at it and do arrows.sign()
  3. Click the sign and try shooting an arrow. Works as expected.
  4. Stop the server.
  5. Restart the server.
  6. Retry step 3 and nothing happens; the sign doesn't react. Expected outcome. same as step 3.

@carlrobert carlrobert changed the title Creating an arrows sign gives an error message at next startup arrows signs are not active after a server restart May 6, 2015
@carlrobert
Copy link
Contributor Author

According to signs/menu.js, it looks like signs should be persistent.

Also, doing arrows.sign() gives a JSON printout in the chat which wasn't there in previous versions, I believe.

@walterhiggins walterhiggins self-assigned this Dec 7, 2016
@walterhiggins walterhiggins added this to the xmas2016 milestone Dec 7, 2016
@walterhiggins
Copy link
Owner

Hi Carl,
I tried reproducing this with SpigotMC 1.10 and could not reproduce the issue. Are you using CanaryMod or SpigotMC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants