Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize already embedded textures #20

Open
Breush opened this issue May 29, 2018 · 0 comments
Open

Optimize already embedded textures #20

Breush opened this issue May 29, 2018 · 0 comments

Comments

@Breush
Copy link
Contributor

Breush commented May 29, 2018

In yoga/model/assimp.cpp, extract_image_nodes does not extract already embedded textures, they are ignored.

Keeping the very same convention than assimp, we could just fill imageNode with:

auto imageNode = new ImageNode();
imageNode->path = "*1"; // Same convention, the 1 is the index of the textures in scene->mTextures
imageNode->bytes = /* extract bytes for scene->mTextures */;
imageNode->bytes_length = /* extract bytes length */;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant