Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pulling Custom Certificates from configMap in W&B Operator #299

Open
flamarion opened this issue Jan 6, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@flamarion
Copy link
Contributor

The W&B Operator currently has support to set the env var SSL_CERT_DIR based on a list of CA Certs directly configured in the values.yaml.

We require additional support to pull custom certificates from a config map and set the same SSL_CERT_DIR env var with them.

We have such support for another chart so I recommend using the same pattern.

Objective:

Extend the functionality of the W&B Operator Helm chart to support setting the SSL_CERT_DIR environment variable using custom certificates from a Kubernetes ConfigMap. This is in addition to the existing functionality of setting SSL_CERT_DIR based on CA Certs configured directly in the values.yaml file.

Current State:

  1. The W&B Operator supports setting the SSL_CERT_DIR environment variable through CA Certs listed directly in the values.yaml file.
  1. Another Helm chart (operator-wandb) already supports pulling custom certificates from a ConfigMap.

Requirements:

  1. Add ConfigMap Support:
  • Update the Helm chart to allow custom certificates to be loaded from a Kubernetes ConfigMap.
  • Follow the same pattern used in the operator-wandb chart to ensure consistency.
  1. Set SSL_CERT_DIR Environment Variable:
  • Ensure that the SSL_CERT_DIR env var is correctly configured to include the custom certificates from the ConfigMap.
  1. Maintain Existing Behavior:
  • Ensure the current functionality (using CA Certs from values.yaml) continues to work seamlessly.
  1. Update values.yaml:
  • Add a new section for configuring the custom ConfigMap.
  • Include comments/documentation on how to use this feature.
  1. Update Deployment Template:
  • Modify the deployment YAML template to support mounting the ConfigMap and configuring the SSL_CERT_DIR environment variable.
  1. Testing:
  • Test both the existing functionality and the new feature.
  • Ensure compatibility with existing workloads.
  • Check the CA Certs are available in the pod

Deliverables:

  1. Updated Helm chart with the new functionality.
  2. Modified values.yaml with example configurations for the custom ConfigMap feature.
  3. Documentation in the README.md (or equivalent) explaining how to configure and use the new functionality.
  4. Validation steps to confirm the feature works as expected.

References:

@flamarion flamarion added the enhancement New feature or request label Jan 6, 2025
@sanster23 sanster23 self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants