Skip to content

Fix/hide description on sidebar when there is no description #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

puskuruk
Copy link
Contributor

No description provided.

@seveibar
Copy link
Contributor

  1. It should actually not show the description box. Use the {description && <ReactElement />} pattern
  2. You can simplify your ternary statement by casting to Boolean. Boolean(description)

@puskuruk puskuruk requested a review from seveibar April 24, 2020 17:14
@seveibar
Copy link
Contributor

nice

@seveibar seveibar merged commit 7b813f4 into master Apr 25, 2020
@seveibar seveibar deleted the fix/hide-description-on-sidebar-when-there-is-no-description branch April 25, 2020 16:10
seveibar pushed a commit that referenced this pull request Apr 25, 2020
## [1.0.5](v1.0.4...v1.0.5) (2020-04-25)

### Bug Fixes

* Fix/hide description on sidebar when there is no description ([#45](#45)) ([7b813f4](7b813f4))
@seveibar
Copy link
Contributor

🎉 This PR is included in version 1.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants