Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently enabling sessions #13

Open
larryfox opened this issue Jul 23, 2015 · 2 comments
Open

Silently enabling sessions #13

larryfox opened this issue Jul 23, 2015 · 2 comments

Comments

@larryfox
Copy link

I just tracked down an issue we we're having with sessions which was caused because this gem silently enables sessions at the Sinatra level. Our product spans a couple Sinatra and plain Rack apps so we use Rack::Session::Cookie as a normal middleware, which causes conflicts with the "Sinatra way".

I'm not sure if it's feasible but I like the approach rack_csrf takes that checks for sessions or raises an error.

@jsmestad
Copy link
Collaborator

@larryfox happy to review and merge in any suggested changes if you can get to that.

@jsmestad
Copy link
Collaborator

Just updated the gem and saw your issue. If you can detail a bit of how you'd see this working, I'd try and pull in the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants