Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Command] warden status Does Not Support Dashes In Env Names #683

Closed
sprankhub opened this issue Jul 25, 2023 · 2 comments · Fixed by #685
Closed

[Command] warden status Does Not Support Dashes In Env Names #683

sprankhub opened this issue Jul 25, 2023 · 2 comments · Fixed by #685
Assignees
Labels
bug Something isn't working

Comments

@sprankhub
Copy link
Contributor

Version of Warden

0.14.1

Operating System and Installation Method

Linux simonpad-t14-gen-3 5.19.0-46-generic #47~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Jun 21 15:35:31 UTC 2 x86_64 x86_64 x86_64 GNU/Linux via Brew

Describe the Bug

warden status shows invalid information for environments containing dashes.

To Reproduce

  1. Create an environment with a dash in the name, e.g. shop-m2.

  2. Run warden status

  3. See invalid information:

     Found the following running environments:
         shopm2 a magento2 project
            Project Directory: /your/dir/shop-m2
            Project URL: https://shopm2.test
    

Expected Behavior

Show valid information:

Found the following running environments:
    shop-m2 a magento2 project
       Project Directory: /home/simon/projects/shop-m2
       Project URL: https://app.shop-m2.test

It definitely needs to show the dashes. However, I also think the Project URL should contain the app. subdomain.

Additional context

No response

@sprankhub sprankhub added the bug Something isn't working label Jul 25, 2023
@bap14
Copy link
Member

bap14 commented Jul 25, 2023

@navarr I'll take this one.

@bap14
Copy link
Member

bap14 commented Jul 30, 2023

@navarr PR opened to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants