Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount hit overwrite #3296

Open
alexeadem opened this issue Dec 14, 2024 · 0 comments
Open

mount hit overwrite #3296

alexeadem opened this issue Dec 14, 2024 · 0 comments

Comments

@alexeadem
Copy link
Contributor

alexeadem commented Dec 14, 2024

Using the following config:

"mounts": [
            {
                "mountpoint": "/one",
                "origin": "callback://protocol-test-one" 
            },
            {
                "mountpoint": "/",
                 "origin": "callback://protocol-test-default" ,
                "extra-mimetypes": {
                    ".map": "application/json"
                }
            }
        ],

Is there any reason not to break here when the hit is found?

hit = hm;
// break;

while loop will continue matching other protocols effectively overwriting the original hit based on path /one and missing to match the right protocol in subsequent calls to lws_http_redirect_hit

Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant