Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and redirect unused signatures #366

Closed
7 tasks done
jeremyfelt opened this issue Mar 31, 2016 · 3 comments
Closed
7 tasks done

Deprecate and redirect unused signatures #366

jeremyfelt opened this issue Mar 31, 2016 · 3 comments

Comments

@jeremyfelt
Copy link
Contributor

jeremyfelt commented Mar 31, 2016

Way back in Spine 1.2.2, we stopped using several (many) of our SVGs and instead went back to using 2 states for each mark. See #210.

Several sites out in the wild still request these SVGs, but it would be nice to avoid maintaining them forever.

I'm watching the logs on repo.wsu.edu and setting up redirects accordingly:

  • wsu-signature-vertical-crimson-gray-graylighter.svg -> wsu-signature-vertical.svg
  • wsu-signature-horizontal-crimson-gray-graylighter.svg -> wsu-signature-horizontal.svg
  • wsu-signature-vertical-crimson-graydark-graylighter.svg -> wsu-signature-vertical-white.svg
  • wsu-signature-horizontal-crimson-graydark-graylighter.svg -> wsu-signature-horizontal-white.svg
  • wsu-signature-vertical-crimson-7d868c-graylightly.svg -> wsu-signature-vertical-white.svg
  • wsu-signature-horizontal-crimson-7d868c-graylightly.svg -> wsu-signature-horizontal-white.svg
  • All location specific versions of the above that have been accessed in the last 30 days - extension, globalcampus, spokane, tricities, vancouver

Once redirects are setup, it should be safe to remove the file from the repository.

@jeremyfelt
Copy link
Contributor Author

I think the only ones really in use are:

198 /spine/1/marks/wsu-signature-vertical-crimson-7d868c-graylightly.svg
3197 /spine/1/marks/wsu-signature-vertical-crimson-gray-graylighter.svg
3996 /spine/1/marks/wsu-signature-vertical-crimson-graydark-graylighter.svg

The others appear to be scans of CSS files hosted elsewhere.

@jeremyfelt
Copy link
Contributor Author

I guess for sanity sake, here's the full list for the last 30 days:

     81 /spine/1/marks/wsu-spokane-signature-vertical.svg
    198 /spine/1/marks/wsu-signature-vertical-crimson-7d868c-graylightly.svg
    468 /spine/1/marks/wsu-signature-vertical.png
    927 /spine/1/marks/wsu-globalcampus-signature-vertical.svg
   1129 /spine/develop/marks/wsu-campaign-signature-vertical-white.svg
   1140 /spine/develop/marks/wsu-foundation-signature-vertical-white.svg
   1143 /spine/develop/marks/wsu-extension-signature-vertical-white.svg
   1145 /spine/develop/marks/wsu-spokane-signature-vertical.svg
   1197 /spine/develop/marks/wsu-spokane-signature-vertical-white.svg
   1233 /spine/develop/marks/wsu-globalcampus-signature-vertical-white.svg
   1430 /spine/develop/marks/wsu-vancouver-signature-vertical-white.svg
   1446 /spine/develop/marks/wsu-globalcampus-signature-vertical.svg
   1512 /spine/develop/marks/wsu-campaign-signature-vertical.svg
   1975 /spine/develop/marks/wsu-vancouver-signature-vertical.svg
   2208 /spine/develop/marks/wsu-healthsciences-signature-vertical.svg
   2209 /spine/develop/marks/wsu-healthsciences-signature-vertical-white.svg
   3197 /spine/1/marks/wsu-signature-vertical-crimson-gray-graylighter.svg
   3996 /spine/1/marks/wsu-signature-vertical-crimson-graydark-graylighter.svg
   5033 /spine/develop/marks/wsu-foundation-signature-vertical.svg
   6293 /spine/1/marks/wsu-signature-vertical-white.svg
   6835 /spine/1/marks/wsu-signature-vertical.svg
   7331 /spine/develop/marks/wsu-tricities-signature-vertical-white.svg
   8474 /spine/develop/marks/wsu-signature-vertical.png
  14660 /spine/develop/marks/wsu-healthsciences-spokane-signature-vertical-white.svg
  16274 /spine/develop/marks/wsu-extension-signature-vertical.svg
  23124 /spine/develop/marks/wsu-healthsciences-spokane-signature-vertical.svg
  29348 /spine/develop/marks/wsu-tricities-signature-vertical.svg
 196505 /spine/develop/marks/wsu-signature-vertical-white.svg
1857995 /spine/develop/marks/wsu-signature-vertical.svg

We should probably tie these to a specific Spine version in the future so that anyone who hosts their own Spine CSS will not be affected by changes we make in version 1.

@jeremyfelt
Copy link
Contributor Author

A new list of the last 30 days and from that, these that should be accounted for on the server:

     98 /spine/1/marks/wsu-signature-horizontal-crimson-graydark-graylighter.svg
    203 /spine/1/marks/wsu-signature-horizontal-crimson-gray-graylighter.svg
    419 /spine/1/marks/wsu-signature-vertical-crimson-7d868c-graylightly.svg
    481 /spine/1/marks/wsu-signature-vertical-crimson-gray-graylighter.svg
   1182 /spine/1/marks/wsu-signature-vertical-crimson-graydark-graylighter.svg

... and they are through redirects. So we're good to remove these from /develop/, /1/, and the new /1.4.4/ release. They will remain in each of the previous minor release directories for anyone that was accessing them there.

@jeremyfelt jeremyfelt added this to the 1.4.4 milestone Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant