Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm-terminal: Handle Composition / IME Events from Mobile Firefox and Sometimes Mobile Chrome #112

Closed
torch2424 opened this issue Oct 10, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@torch2424
Copy link

It's actually a bug in firefox, so simply watch this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1587934

@torch2424 torch2424 added the bug Something isn't working label Oct 10, 2019
@torch2424 torch2424 self-assigned this Oct 10, 2019
@torch2424
Copy link
Author

torch2424 commented Oct 11, 2019

Actually bug was resolved as it being a bug in the mdn example code? 🤔

All in all, I think there is some weird behavior going on in mobile browsers concerning this. For example: https://stackoverflow.com/questions/42011740/event-preventdefault-not-working-for-android-chrome . Thus, we need to set the input using JS on every keypress, suing something like xterm's onKey.

However, another case I am curious about is: https://davidwalsh.name/disable-autocorrect . Because this also does not seem to work in firefox mobile, but it may also be concerned with the mobile firefox composition mode?

Doing more reaserch, yes, it is all up to compisition mode: ianstormtaylor/slate#2062 and https://blog.evanyou.me/2014/01/03/composition-event/

@torch2424 torch2424 changed the title Fix wasm-terminal taking duplicate input in the Xterm textarea Wasm-temrinal: Handle Composition / IME Events from Mobile Firefox and Sometimes Mobile Chrome Oct 11, 2019
@torch2424 torch2424 changed the title Wasm-temrinal: Handle Composition / IME Events from Mobile Firefox and Sometimes Mobile Chrome Wasm-terminal: Handle Composition / IME Events from Mobile Firefox and Sometimes Mobile Chrome Oct 11, 2019
@Michael-F-Bryan
Copy link
Contributor

I don't believe this is relevant now that we've rewritten the package as @wasmer/sdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants