Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit Send and Sync #1734

Closed
Yamakaky opened this issue Oct 18, 2020 · 1 comment · Fixed by #2892
Closed

Explicit Send and Sync #1734

Yamakaky opened this issue Oct 18, 2020 · 1 comment · Fixed by #2892
Labels
📚 documentation Do you like to read? 🎉 enhancement New feature! priority-medium Medium priority issue
Milestone
v3.0

Comments

@Yamakaky
Copy link

Yamakaky commented Oct 18, 2020 •
edited
Loading

Motivation

Currently, it is unclear which types are meant to be Send and/or Sync. For example:

  • Memory is Sync, but Instance is not
  • Functionis Sync but NativeFunc is not

The syncness is also due to auto impl which can change with the implementation.

Proposed solution

Add Sync, !Sync, Send and !Send implementation for all major types, including Instance, Module, Function, NativeFunc, Exports, Memory and others I may have missed. Basically, any type with Arc inside, I think. Sync and Send would then be part of the public API.
@Yamakaky Yamakaky added the 🎉 enhancement New feature! label Oct 18, 2020
@Hywan Hywan added the 📚 documentation Do you like to read? label Jul 16, 2021
@Amanieu Amanieu added the priority-medium Medium priority issue label Oct 20, 2021
@Amanieu Amanieu self-assigned this Oct 20, 2021
@heyjdp heyjdp added this to the v3.0 milestone Apr 27, 2022
@syrusakbary
Copy link
Member

We believe this issue will be solved by the Wasmer 3.0 refactor. We will re-test this upon the release

@Amanieu Amanieu mentioned this issue May 20, 2022
Merged
8 tasks
@bors bors bot closed this as completed in #2892 Jul 19, 2022
@bors bors bot closed this as completed in 06474c1 Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📚 documentation Do you like to read? 🎉 enhancement New feature! priority-medium Medium priority issue
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

Implement new Context API for Wasmer 3.0 wasmerio/wasmer
5 participants
@syrusakbary @Amanieu @Hywan @Yamakaky @heyjdp