Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile with js feature on nightly rustc #5214

Closed
anlumo opened this issue Nov 4, 2024 · 0 comments · Fixed by #5226
Closed

Can't compile with js feature on nightly rustc #5214

anlumo opened this issue Nov 4, 2024 · 0 comments · Fixed by #5226
Assignees

Comments

@anlumo
Copy link

anlumo commented Nov 4, 2024

Describe the bug

This is a continuation of #4468, which was closed as not planned for some reason. Wasmer 5.0.0 doesn't compile on nightly rustc on the wasm32-unknown-unknown target any more when the js feature is enabled due to this line:

#![cfg_attr(feature = "js", crate_type = "cdylib")]

rustc -vV
rustc 1.84.0-nightly (b8c8287a2 2024-11-03)
binary: rustc
commit-hash: b8c8287a229cd79604aa84c25e1235fc78cd5f2e
commit-date: 2024-11-03
host: x86_64-unknown-linux-gnu
release: 1.84.0-nightly
LLVM version: 19.1.3

Note that nightly is necessary for multithreading support on Web, I can't use stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants