Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Trap more similar to wasmtime::Trap #517

Closed
Robbepop opened this issue Oct 14, 2022 · 0 comments · Fixed by #559
Closed

Make Trap more similar to wasmtime::Trap #517

Robbepop opened this issue Oct 14, 2022 · 0 comments · Fixed by #559
Labels
tech-debt An issue to resolve some technical debt.

Comments

@Robbepop
Copy link
Member

Currently our Trap definition differs greatly from the wasmtime::Trap definition and API.

Since one of our goals is to provide a mirroring API to the well established Wasmtime API we should improve the mirroring in this regard. This requires us to get rid of the wasmi_core::HostError and instead use anyhow::Error or simply an internal String representation or whatever Wasmtime does in that regard.
@Robbepop Robbepop added enhancement New feature or request wasmi-v1 labels Oct 14, 2022
@Robbepop Robbepop added tech-debt An issue to resolve some technical debt. and removed wasmi-v1 enhancement New feature or request labels Oct 25, 2022
This was referenced Nov 5, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt An issue to resolve some technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor wasmi_core::Trap and make it more similar to Wasmtime's Trap wasmi-labs/wasmi
1 participant
@Robbepop