-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kustomize Manifest Ignores Image Entrypoint #55
Comments
This issue has been inactive for 60 days. If the issue is still relevant please comment to re-activate the issue. If no action is taken within 7 days, the issue will be marked closed. |
This still needs looking into. |
This issue has been inactive for 60 days. If the issue is still relevant please comment to re-activate the issue. If no action is taken within 7 days, the issue will be marked closed. |
I checked this on master and there does not seem to be any additional endpoint in the kustomize config. Basically it is the same as in helm. I would consider this fixed and close it. |
@toelke I cannot reproduce this. I propose that we remove the kustomize instructions from README.md. They contain a StatefulSet instead of a Deployment (https://github.com/wave-k8s/wave/blob/master/config/default/manager/manager.yaml) which is rather odd and I do not see any good reason for that. However, as you can see in the link above the entrypoint is set to default and this bug is definitely (not longer) there. Still I doubt that this will work well since it lacks all args we set in helm (https://github.com/wave-k8s/wave/blob/master/charts/wave/templates/deployment.yaml#L26). |
The Kustomize configuration for Wave executes the
/bin/manager
command as the entrypoint for the manager container. It looks like some recent Dockerfile changes have altered the name of this binary and subsequently attempting to deploy master or v0.3.0 using Kustomize fails.Suggestions:
Rely on the containers default entrypoint, or reference a specific image tag to make this reproducible and avoidable in the future.
The text was updated successfully, but these errors were encountered: