Skip to content
This repository was archived by the owner on Aug 6, 2024. It is now read-only.

Account auto-negotiation kicks in before configuration from config server is applied #51

Closed
snicoll opened this issue May 10, 2020 · 2 comments

Comments

@snicoll
Copy link
Contributor

snicoll commented May 10, 2020

If you have configured an existing account (api token) using Spring Cloud's config server, the starter attempts to auto-negotiate an account anyway.

It looks like the configuration from the config server is not available when EnvironmentPostProcessor runs.

@snicoll snicoll added the bug label May 10, 2020
@snicoll snicoll added this to the 2.0.0 milestone May 10, 2020
@snicoll snicoll self-assigned this May 10, 2020
@snicoll snicoll removed the bug label May 10, 2020
@snicoll snicoll removed this from the 2.0.0 milestone May 10, 2020
@snicoll
Copy link
Contributor Author

snicoll commented May 10, 2020

Actually, this is not a bug here but a limitation of Spring Cloud Server that is mutating the environment at the wrong phase, see spring-cloud/spring-cloud-commons#608.

I've asked if a reasonable workaround exists and we'll apply it here accordingly.

@snicoll
Copy link
Contributor Author

snicoll commented May 11, 2020

Unfortunately, I don't think that's reasonable to move the logic elsewhere just for config server. In the meantime I've added support for checking if wavefront.freemium-account is set, see #48.

If that property is set to false alongside the api-token, things will work as expected.

@snicoll snicoll closed this as completed May 11, 2020
@snicoll snicoll removed their assignment May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant