work with cmd+N but not clicking the "terminal" button

Author: weilirs

frontend/app/store/keymodel.ts

@@ -8,6 +8,7 @@ import {
     getAllBlockComponentModels,
     getApi,
     getBlockComponentModel,
+    getSettingsKeyAtom,
     globalStore,
     refocusNode,
     WOS,
@@ -162,12 +163,23 @@ function globalRefocus() {
 }
 
 async function handleCmdN() {
+    const termAutoClose = globalStore.get(getSettingsKeyAtom("term:autoclose")) as boolean | undefined;
+    const termAutoCloseOnError = globalStore.get(getSettingsKeyAtom("term:autocloseonerror")) as boolean | undefined;
+    const termAutoCloseDelay = globalStore.get(getSettingsKeyAtom("term:autoclosedelay")) as number | undefined;
+
     const termBlockDef: BlockDef = {
         meta: {
             view: "term",
             controller: "shell",
+            "cmd:closeonexitforce": termAutoCloseOnError ?? false,
+            "cmd:closeonexitdelay": termAutoCloseDelay ?? 2000,
         },
     };
+    if (termAutoClose && !termAutoCloseOnError) {
+        termBlockDef.meta["cmd:closeonexitforce"] = false;
+        termBlockDef.meta["cmd:closeonexitdelay"] = termAutoCloseDelay ?? 2000;
+        termBlockDef.meta["cmd:closeonexit"] = true;
+    }
     const layoutModel = getLayoutModelForStaticTab();
     const focusedNode = globalStore.get(layoutModel.focusedNode);
     if (focusedNode != null) {

frontend/types/gotypes.d.ts

@@ -601,6 +601,9 @@ declare global {
         "term:copyonselect"?: boolean;
         "term:transparency"?: number;
         "term:allowbracketedpaste"?: boolean;
+        "term:autoclose"?: boolean;
+        "term:autocloseonerror"?: boolean;
+        "term:autoclosedelay"?: number;
         "editor:minimapenabled"?: boolean;
         "editor:stickyscrollenabled"?: boolean;
         "editor:wordwrap"?: boolean;

pkg/wconfig/metaconsts.go

@@ -35,6 +35,9 @@ const (
 	ConfigKey_TermCopyOnSelect               = "term:copyonselect"
 	ConfigKey_TermTransparency               = "term:transparency"
 	ConfigKey_TermAllowBracketedPaste        = "term:allowbracketedpaste"
+	ConfigKey_TermAutoClose                  = "term:autoclose"
+	ConfigKey_TermAutoCloseOnError           = "term:autocloseonerror"
+	ConfigKey_TermAutoCloseDelay             = "term:autoclosedelay"
 
 	ConfigKey_EditorMinimapEnabled           = "editor:minimapenabled"
 	ConfigKey_EditorStickyScrollEnabled      = "editor:stickyscrollenabled"

pkg/wconfig/settingsconfig.go

@@ -62,6 +62,9 @@ type SettingsType struct {
 	TermCopyOnSelect        *bool    `json:"term:copyonselect,omitempty"`
 	TermTransparency        *float64 `json:"term:transparency,omitempty"`
 	TermAllowBracketedPaste *bool    `json:"term:allowbracketedpaste,omitempty"`
+	TermAutoClose           *bool    `json:"term:autoclose,omitempty"`
+	TermAutoCloseOnError    *bool    `json:"term:autocloseonerror,omitempty"`
+	TermAutoCloseDelay      *float64 `json:"term:autoclosedelay,omitempty"`
 
 	EditorMinimapEnabled      bool    `json:"editor:minimapenabled,omitempty"`
 	EditorStickyScrollEnabled bool    `json:"editor:stickyscrollenabled,omitempty"`