Inconsistent Appearance of Window Control Buttons with Native Title Bar Disabled

[jbwfu]

When the window:nativetitlebar is set to false, the appearance of the window control buttons is highly inconsistent with the overall design of the application. Is it possible for Wave to improve this through code adjustments?

I'm using Debian 12 with GNOME 43.9 on an X11 environment and Wave version v0.10.4.

[esimkowitz]

Ah yeah this is a bug related to #1173

We did a big refactor of our window management code to use multiple WebContentsViews that we swap around within an Electron window, which lets us achieve much faster tab switching, etc. It seems, though, that this breaks the Electron implementation of the Window Controls Overlay API, which we use to create the window control buttons when nativetitlebar is unset. I think we can fix this by using BrowserWindow instead of BaseWindow, but I need to look into the tradeoffs of this before implementing