Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troll-proofing via dependency injection #6

Open
ianfixes opened this issue Mar 30, 2017 · 1 comment
Open

Troll-proofing via dependency injection #6

ianfixes opened this issue Mar 30, 2017 · 1 comment

Comments

@ianfixes
Copy link

I noticed #2 and #5, which gave me a chuckle but probably have no place in this project.

Is there any reason that the classes here

couldn't be replaced by some injected JSON?

That way, site-specific overrides could be provided for folks who feel a moral obligation to push the boundaries here, and you wouldn't become an arbiter of what goes on that list of classes. I'd be happy to submit a PR for this if you like, although it would (by nature) affect the existing structure a fair amount.

@waxim
Copy link
Owner

waxim commented Mar 30, 2017

I guess they could be. The problem I was having was the fact that a version of each pronoun is needed, so I wanted to enforce some schema on that but in light of alot of the feedback and the translations asked for I'm going to look at a refactor and maybe provide my list as a "plugin" instead of the basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants