Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: specify output for NewLayerShellSettings #94

Open
id3v1669 opened this issue Nov 24, 2024 · 4 comments
Open

Feature request: specify output for NewLayerShellSettings #94

id3v1669 opened this issue Nov 24, 2024 · 4 comments

Comments

@id3v1669
Copy link

Add some kind of variable for NewLayerShellSettings to have ability declare output.
Example scenario: App starts with StartMode::Background and subscribes for some kind of event and needs to be shown on a specific screen when triggered or follow some kind of dev logic.

Current workaround:
set size as 1x1 pixel, fg and bt to TRANSPARENT, layer: Layer::Background, and keep using StartMode::TargetScreen.
That workaround is ugly and covers static solution, but still doesn't allow to create custom logic to pick screen for new window in multiapp.

@Decodetalkers
Copy link
Collaborator

about this feature, I have create a pr: #86

but seems there are still many problems, because now I do not have subscreen..

@id3v1669
Copy link
Author

about this feature, I have create a pr: #86

but seems there are still many problems, because now I do not have subscreen..

Just tried out your pr, unfortunately ChosenOutput doesn't work for me.
Anyway, should I close this issue as pr is present or keep it open until fixed and merged?

@Decodetalkers
Copy link
Collaborator

about this feature, I have create a pr: #86

but seems there are still many problems, because now I do not have subscreen..

Just tried out your pr, unfortunately ChosenOutput doesn't work for me.
Anyway, should I close this issue as pr is present or keep it open until fixed and merged?

Emm.. keep this pr open. Emm, these days I do not have much time, and also I do not have a subscreen, the origin one is damaged. Can you help me finish this pr?

@id3v1669
Copy link
Author

id3v1669 commented Nov 25, 2024

Emm.. keep this pr open. Emm, these days I do not have much time, and also I do not have a subscreen, the origin one is damaged. Can you help me finish this pr?

I'll try my best, but can't promise anything.
Will continue conversation in comments to your pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants