Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Branch Creation Requirements #7

Open
jhpierce opened this issue Mar 28, 2022 · 0 comments
Open

Define Branch Creation Requirements #7

jhpierce opened this issue Mar 28, 2022 · 0 comments
Labels

Comments

@jhpierce
Copy link
Collaborator

jhpierce commented Mar 28, 2022

Design Challenge

Where are branch names defined? Is it ok if they already exist? Users must have custom branch names, so where will they specify those branch names?

Requirements

  • Branches must be known at the pre-processing phase for async and sync code modifications.
  • They must be unlikely to collide with existing branches
  • They must be deterministically built from the changeset, so that given a changeset you know exactly which branch it would create PRs on. This way, we can look up existing branches and decide to short-circuit or not in pre-processing based on commit history
@jhpierce jhpierce changed the title Define Branch Creation Pattern Define Branch Creation Requirements Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant