Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the agent accept a server address as URL #243

Closed
Tracked by #241
vikman90 opened this issue Oct 25, 2024 · 2 comments · Fixed by #258
Closed
Tracked by #241

Let the agent accept a server address as URL #243

vikman90 opened this issue Oct 25, 2024 · 2 comments · Fixed by #258
Assignees
@aritosteles
Labels
level/task Task issue module/agent mvp Minimum Viable Product refinement type/enhancement Enhancement issue

Comments

@vikman90
Copy link
Member

vikman90 commented Oct 25, 2024 •
edited by TomasTurina
Loading

Parent Issue: #241

Replace the manager_ip setting with server_url. This setting shall accept a URL:

  • Accept both HTTP and HTTPS.
  • Accept IP addresses, names, and FQDNs.

Example

server_url:       https://server.wazuh.com.test:27000
registration_url: https://server.wazuh.com.test:55000
@vikman90 vikman90 mentioned this issue Oct 25, 2024
Open
53 tasks
@vikman90 vikman90 added level/task Task issue type/enhancement Enhancement issue phase/mvp module/packages Agent packages module/agent and removed module/packages Agent packages labels Oct 25, 2024
@wazuhci wazuhci moved this to Triage in Release 5.0.0 Oct 25, 2024
@wazuhci wazuhci moved this from Triage to Backlog in Release 5.0.0 Oct 25, 2024
@wazuhci wazuhci moved this from Backlog to In progress in Release 5.0.0 Oct 25, 2024
@aritosteles aritosteles mentioned this issue Oct 28, 2024
Merged
1 task
@aritosteles aritosteles linked a pull request Oct 28, 2024 that will close this issue
Let the agent accept a server address as URL #258
Merged
1 task
@vikman90 vikman90 added mvp Minimum Viable Product refinement and removed mvp labels Oct 29, 2024
@vikman90
Copy link
Member Author

Issue Update

October 31

@aritosteles
Copy link
Contributor

aritosteles commented Oct 31, 2024 •
edited
Loading

Update

October 30

  • Config settings renamed to server_url and registration_url. Port and UseHttps settings removed. All classes, functions and tests involved were refactored.
  • Added boost::urls for url parsing and validation.
    • Parsing and validation done in HttpRequestParams, Communicator and AgentRegistration classes.
    • In case of ill-formated urls in config file a log entry is created, no crash or exceptions thrown. More thorough validation of config settings is in order.
  • HttpRequestParams class moved to its own hpp and cpp files.
    -Added flag --output-on-failure to ctest execution to help debug failing tests.

PR is on final review

@wazuhci wazuhci moved this from In progress to Done in Release 5.0.0 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aritosteles aritosteles

Labels
level/task Task issue module/agent mvp Minimum Viable Product refinement type/enhancement Enhancement issue
Projects
Release 5.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Let the agent accept a server address as URL wazuh/wazuh-agent
2 participants
@vikman90 @aritosteles