Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom branding: add support to update multiple settings at a time #4450

Closed
2 tasks done
Tracked by #4392
Desvelao opened this issue Sep 7, 2022 · 3 comments · Fixed by #4501
Closed
2 tasks done
Tracked by #4392

Custom branding: add support to update multiple settings at a time #4450

Desvelao opened this issue Sep 7, 2022 · 3 comments · Fixed by #4501
Assignees
@Desvelao
Labels
type/enhancement Enhancement issue

Comments

@Desvelao
Copy link
Member

Desvelao commented Sep 7, 2022 •
edited
Loading

Description

Currently, the endpoint to update the plugin's settings only supports updating a setting at a time.

This means that if multiple settings are modified from the UI at the same time, the app will make a request for each of them to the NodeJS backend. This situation can be improved by redesigning the endpoint to allow the modification of every allowed setting in a single request.

Goal

  • Extend the /utils/configuration endpoint to allow updating multiple settings at the same time.

Depends on #4443.

Tasks

  • Refactor the frontend and backend to send/manage/support multiple setting configurations in the same request.
  • Tests
@Desvelao Desvelao added the type/enhancement Enhancement issue label Sep 7, 2022
@Desvelao
Copy link
Member Author

Desvelao commented Sep 7, 2022 •
edited by AlexRuiz7
Loading

  • Refactored the frontend and backend to support the update and reading of multiple settings in the same request.

@Desvelao Desvelao self-assigned this Sep 8, 2022
@Desvelao Desvelao moved this to Triage in Release 4.4.0 Sep 8, 2022
@Desvelao Desvelao moved this from Triage to In Progress in Release 4.4.0 Sep 8, 2022
@Desvelao Desvelao mentioned this issue Sep 8, 2022
Closed
@Desvelao Desvelao linked a pull request Sep 8, 2022 that will close this issue
Define the plugin settings schema, add customization of reports #4461
Closed
@Desvelao
Copy link
Member Author

Desvelao commented Sep 8, 2022 •
edited by AlexRuiz7
Loading

  • Fixed a minor problem with the type of parameters received in the backend.

@AlexRuiz7 AlexRuiz7 mentioned this issue Sep 12, 2022
Closed
13 tasks
@AlexRuiz7 AlexRuiz7 changed the title Enhance the endpoint to update the plugin settings Enhance the endpoint to update the plugin's settings Sep 12, 2022
@Desvelao Desvelao mentioned this issue Sep 13, 2022
Merged
@Desvelao Desvelao linked a pull request Sep 13, 2022 that will close this issue
Centralize the plugin settings #4501
Merged
@gdiazlo gdiazlo changed the title Enhance the endpoint to update the plugin's settings Add support to update multiple settings at a time Sep 13, 2022
@AlexRuiz7 AlexRuiz7 changed the title Add support to update multiple settings at a time Custom branding: add support to update multiple settings at a time Sep 14, 2022
@AlexRuiz7 AlexRuiz7 moved this from In Progress to On Hold in Release 4.4.0 Sep 16, 2022
@Desvelao
Copy link
Member Author

Changes

  • Add tests for:
    • /utils/* API endpoints

Redone some tests that required the plugin platform was up manually.

@vikman90 vikman90 added this to the Release 4.4.0 milestone Sep 26, 2022
@Desvelao Desvelao moved this from On Hold to In Review in Release 4.4.0 Oct 11, 2022
Repository owner moved this from In Review to Done in Release 4.4.0 Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Desvelao Desvelao

Labels
type/enhancement Enhancement issue
Projects
No open projects
Release 4.4.0
Status: Done
Milestone
No milestone
3 participants
@vikman90 @AlexRuiz7 @Desvelao