Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken breadcrumbs in Wazuh Dashboard 2.x #4502

Closed
Tracked by #4160
yenienserrano opened this issue Sep 13, 2022 · 3 comments · Fixed by #4649
Closed
Tracked by #4160

Broken breadcrumbs in Wazuh Dashboard 2.x #4502

yenienserrano opened this issue Sep 13, 2022 · 3 comments · Fixed by #4649
Assignees
Labels
platform/wazuh Affects the application when deployed on the Wazuh-Dashboard platform. type/bug Bug issue

Comments

@yenienserrano
Copy link
Member

yenienserrano commented Sep 13, 2022

Wazuh OSD
4.4 2.2.1
Browser
Chrome, Firefox, Safari

Description
New styles added to the breadcrumbs in this OSD issue breaks our custom breadcrumbs, along with other issues:

  • Logo rendering.
  • API selector tag.
  • Breadcrumbs.

This issue happens in OpenSearch Dashboards v2.2.1 and higher.

Preconditions

  1. OSD 2.2.1 up and running

Steps to reproduce

  1. Navigate to Wazuh
  2. See the navigation bar

Expected Result
image

Actual Result
image

@yenienserrano yenienserrano added the type/bug Bug issue label Sep 13, 2022
@gdiazlo gdiazlo added the platform/wazuh Affects the application when deployed on the Wazuh-Dashboard platform. label Sep 24, 2022
@AlexRuiz7 AlexRuiz7 changed the title Breadcrumbs are broken in OSD 2.2.1 Breadcrumbs are broken in OSD >2.2.1 Sep 27, 2022
@AlexRuiz7 AlexRuiz7 changed the title Breadcrumbs are broken in OSD >2.2.1 Broken breadcrumbs in OpenSearch Dashboards 2.2.1 and higher Sep 27, 2022
@AlexRuiz7 AlexRuiz7 changed the title Broken breadcrumbs in OpenSearch Dashboards 2.2.1 and higher Broken breadcrumbs in Wazuh Dashboard 2.x Sep 30, 2022
@Machi3mfl
Copy link
Member

Machi3mfl commented Oct 5, 2022

Task progress

Researching the styles in the Open search Navbar and I found:

  • Problems with a class called osdBreadcrumbs that add a CSS filter and cover the entire navbar.
    If we remove this CSS property the breadcrumb is fixed but the problem is that is a default Open search style.

image

We cannot modify the style because is a native osd style. I'm researching how to fix it without overriding the style.

Differences between breadcrumb styles in <2.x and >2.x

Breadcrumbs inside plugins

  • In Open Search dashboard 2.x
    Selection_053

  • In Open Search dashboard 1.x
    image

The current style in the Breadcrumbs links has a rectangle with rounded borders. In our case, we have in the first link the wazuh logo and the dropdown menu. Then the navigation link.
If we remove and adjust some CSS styles the osdBreadcrumbs breadcrumb would be like this:

image

Important

We need to consider if we want to follow the OpenSearch style and add it to our breadcrumb.

@Machi3mfl
Copy link
Member

We decided to replicate the OpenSearch 2.x Breadcrumb style in our Breadcrumb.

Next Steps

  • Replicate the OSD style in this PR
  • Verify how is the Breadcrumb style for Elastic and decide if we need to replace it.
  • Decide if the style changes will be only applied to Wazuh Dashboard or Elastic too.

@yenienserrano yenienserrano self-assigned this Oct 13, 2022
@yenienserrano
Copy link
Member Author

The new form of the breadcrumb is

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/wazuh Affects the application when deployed on the Wazuh-Dashboard platform. type/bug Bug issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants