Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoder information is displayed before closing the flyout with the information #5219

Closed
Desvelao opened this issue Feb 21, 2023 · 1 comment · Fixed by #5597
Closed

Decoder information is displayed before closing the flyout with the information #5219

Desvelao opened this issue Feb 21, 2023 · 1 comment · Fixed by #5597
Assignees
Labels
level/task Task issue type/bug Bug issue

Comments

@Desvelao
Copy link
Member

Desvelao commented Feb 21, 2023

Wazuh Elastic Rev Security
4.x 7.x 4xxx Basic, ODFE, Xpack
Browser
Chrome, Firefox, Safari, etc

Description
The flyout that displays information related to a decoder displays information about another decoder when clicking in the button/link to open the content of file that contains the decoder.

image

Preconditions
1.

Steps to reproduce

  1. Navigate to Management/Decoders
  2. Click on any row of the decoders table. A flyout will be opened with data from the selected decoder.
  3. In the table of Related decoders clicks on a button/link of File column.
  4. The data of the decoder will be displayed in the flyout and this will be closed to open the decoder file that contains the decoder definition.

Expected Result
1.

Actual Result
1.

Screenshots

The selected decoder in the main table of Management/Decoders
image

The decoder info displayed in the flyout changes to another one. After that, the flyout is closed to display the decoder file content that contains the selected decoder.
image

Additional context
Add any other context about the problem here. Here you can paste log entries too or any other useful information that may help with the issue.

@Desvelao Desvelao added the type/bug Bug issue label Feb 21, 2023
@Desvelao
Copy link
Member Author

Research

This problem is caused because the handler to open the decoder file content, doesn't stop the event propagation. This causes the onClick event of the table row will be fired, updating the decoder info displayed in the flyout.

This is not happening in the rule info flyout. The handler for this case, stops the event propagation.

Decoder: https://github.com/wazuh/wazuh-kibana-app/blob/4.5/public/controllers/management/components/management/decoders/views/decoder-info.tsx#L34-L52
Rule: https://github.com/wazuh/wazuh-kibana-app/blob/4.5/public/controllers/management/components/management/ruleset/views/rule-info.tsx#L53-L76

Stop event propagation in rule info flyout: https://github.com/wazuh/wazuh-kibana-app/blob/4.5/public/controllers/management/components/management/ruleset/views/rule-info.tsx#L54

@gdiazlo gdiazlo added the level/task Task issue label Apr 19, 2023
@yenienserrano yenienserrano self-assigned this Jun 26, 2023
@wazuhci wazuhci moved this to In progress in Release 4.7.0 Jun 27, 2023
@yenienserrano yenienserrano linked a pull request Jun 27, 2023 that will close this issue
6 tasks
@wazuhci wazuhci moved this from In progress to Pending review in Release 4.7.0 Jun 27, 2023
@wazuhci wazuhci moved this from Pending review to Blocked in Release 4.7.0 Jul 3, 2023
@wazuhci wazuhci moved this from Blocked to Pending final review in Release 4.7.0 Jul 11, 2023
@wazuhci wazuhci moved this from Pending final review to Done in Release 4.7.0 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/bug Bug issue
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants