Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vulnerabilities dashboard] Replace the Inventory tab using OSD plugins #5895

Closed
3 tasks done
Tracked by #5763
Machi3mfl opened this issue Sep 18, 2023 · 4 comments · Fixed by #6047
Closed
3 tasks done
Tracked by #5763

[Vulnerabilities dashboard] Replace the Inventory tab using OSD plugins #5895

Machi3mfl opened this issue Sep 18, 2023 · 4 comments · Fixed by #6047
Assignees
Labels
level/subtask Subtask issue type/enhancement Enhancement issue

Comments

@Machi3mfl
Copy link
Member

Machi3mfl commented Sep 18, 2023

Description

Replace the Inventory tab using OSD plugins (Dashboard/Embeddables/Visualizations Builder) - More details below-

Check 2.10.0 discover design

Screenshot 2023-10-03 at 12 03 33

Components

  • Searchbar
  • Sidebar with fields selector (Example: src/plugins/data_explorer/public/components/sidebar/index.tsx)
<EuiPageSideBar />
  • Table with details flyout (Example: src/plugins/discover/public/application/components/data_grid/data_grid_table.tsx)
<EuiDataGrid />
<EuiFlyout />

Opensearch UI 1.3.0

Tasks

  • Create the inventory tab considering to use native OUI components
  • Use the search bar service created
  • Add a search bar component to filter the events
@Machi3mfl Machi3mfl added type/enhancement Enhancement issue level/subtask Subtask issue labels Sep 18, 2023
@wazuhci wazuhci moved this to Triage in Release 4.8.0 Sep 18, 2023
@Machi3mfl Machi3mfl changed the title [Vulnerabilities dashboard] Replace the Inventory tab using OSD plugins [Vulnerabilities dashboard] Replace the Inventory tab using OSD plugins Sep 18, 2023
@Machi3mfl Machi3mfl self-assigned this Sep 18, 2023
@wazuhci wazuhci moved this from Triage to In progress in Release 4.8.0 Sep 18, 2023
@Machi3mfl
Copy link
Member Author

New inventory tab

New features

  • DataGrid
  • Flyout with document details
  • Index pattern search

Screenshot 2023-10-20 at 10 29 58

Screenshot 2023-10-20 at 10 30 15

@Machi3mfl Machi3mfl linked a pull request Oct 23, 2023 that will close this issue
6 tasks
@Machi3mfl
Copy link
Member Author

Screen.Recording.2023-10-23.at.15.05.15.mov

@Machi3mfl
Copy link
Member Author

Machi3mfl commented Oct 24, 2023

New vulnerabilities inventory

Search bar

The search bar connected to the new vulnerabilities index

Screenshot 2023-10-24 at 15 34 07

Data Grid

Screenshot 2023-10-24 at 15 32 52

The data grid component has the following features:

  • Table columns selector to switch the table columns visibility
Screenshot 2023-10-24 at 15 35 33
  • Column sorter, adds the possibility to sort by all the columns
Screenshot 2023-10-24 at 15 36 49
  • Pagination and rows per page selector
Screenshot 2023-10-24 at 15 40 03
  • Document details by clicking on the table row
Screenshot 2023-10-24 at 15 42 10

Demo

Screen.Recording.2023-10-24.at.15.46.13.mov

@Machi3mfl
Copy link
Member Author

Considerations

When the index pattern has a wrong template the order and hide/show columns will be shown fields with type keyword.
These types make a wrong behavior when we try to order by these fields or shown in the table.

image

To fix it it's important to create the index and mappings correctly following these steps: #5966 (comment)

Then, the keyboard fields will disappear from the column select and will be sorted correctly by all the index fields.

Screen.Recording.2023-10-25.at.10.52.34.mov

@wazuhci wazuhci moved this from In progress to Done in Release 4.8.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/subtask Subtask issue type/enhancement Enhancement issue
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant