Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems switching between modules and agents applications #5900

Closed
8 of 9 tasks
Desvelao opened this issue Sep 19, 2023 · 2 comments · Fixed by #5926, #5972, #5983, #5986 or #6056
Closed
8 of 9 tasks

Problems switching between modules and agents applications #5900

Desvelao opened this issue Sep 19, 2023 · 2 comments · Fixed by #5926, #5972, #5983, #5986 or #6056
Assignees
Labels
level/task Task issue type/enhancement Enhancement issue

Comments

@Desvelao
Copy link
Member

Desvelao commented Sep 19, 2023

Some problems have been found,

  • When you change application quickly, sometimes it gives you an error in the console and shows you the previous view to the currently selected one.
screenshot

image

  • Sometimes when you want to enter to some module it always redirects you to the Endpoints summary.
screenshot

image

  • Problems with the tabView in the url, in the views you should change the value but then returns to the previous value.
screenshot

image

image

  • When navigating to an agent from the agent table is not working

  • In the Statistics plugin the same thing is happening with the settings button, it redirects to a wazuh-plugin-settings and should redirect to settings.

https://github.com/wazuh/wazuh-dashboard-plugins/blob/feat/83-move-menu-items-to-applications/plugins/main/public/controllers/management/components/management/statistics/statistics-overview.js#L203

  • redirection of an agent to some group as it has to redirect to the groups plugin and is trying to go to endpoint-group.

https://github.com/wazuh/wazuh-kibana-app/blob/feat/83-move-menu-items-to-applications/plugins/main/public/components/common/util/agent-group-truncate/group-truncate.tsx#L55

https://github.com/wazuh/wazuh-kibana-app/blob/feat/83-move-menu-items-to-applications/plugins/main/public/controllers/management/components/management/configuration/configuration-switch.js#L214

Problem 1 and 2 may be related because it occurs when you click twice in a row on the endpoint summary and then want to go to another module, or click twice in a row on a module and navigate to the endpoint summary.

  • adapt the navigation between the applications

Originally posted by @yenienserrano in #5820 (comment)

  • Whenever a user uses OpenSearch new Discover plugin the browser console throws an exception
Error: ScopedHistory instance has fell out of navigation scope for basePath

Summary

How to replicate the issue:

  • Go to the new Discover plugin
    image

  • Go to Threat Hunting module (or any dashboard module)

  • See the error in the console

The exception is thrown in the Scope History class of the Core features of the platform and it doesn't seem to break the expected use of the Dashboards or Events tabs.

This issue has been reported in OpenSearch and seems to be due to an incompatibility between the Legacy Discover and the New Discover plugin.

OpenSearch will not fix this error because will deprecate the Legacy Discover in version 2.11.0. The course of action to be taken is to deprecate Wazuh Kibana Discover module in a future release.

OpenSearch issue

opensearch-project/OpenSearch-Dashboards#4698

Screenshot

image

  • Problem with changing api

There are problems when you have several apis and you select one that is not the first to connect, when you want to change plugins it makes several requests to know the apis and the view freezes for a while.

Also when changing api when it is not the first to connect it takes a long time and sometimes it doesn't make the change.

@Desvelao Desvelao added type/enhancement Enhancement issue level/task Task issue labels Sep 19, 2023
@yenienserrano yenienserrano self-assigned this Sep 21, 2023
@wazuhci wazuhci moved this to In progress in Release 4.8.0 Sep 21, 2023
@yenienserrano yenienserrano mentioned this issue Sep 25, 2023
6 tasks
@yenienserrano yenienserrano linked a pull request Sep 25, 2023 that will close this issue
6 tasks
@wazuhci wazuhci moved this from In progress to On hold in Release 4.8.0 Sep 25, 2023
@wazuhci wazuhci moved this from On hold to In progress in Release 4.8.0 Sep 27, 2023
@wazuhci wazuhci moved this from In progress to On hold in Release 4.8.0 Sep 27, 2023
@wazuhci wazuhci moved this from On hold to In progress in Release 4.8.0 Sep 29, 2023
@Desvelao
Copy link
Member Author

Desvelao commented Oct 3, 2023

Moved to on hold.

Some problems appear when the page is refreshed due to the application being mounted. We have decided to keep this refresh.

@wazuhci wazuhci moved this from In progress to On hold in Release 4.8.0 Oct 3, 2023
@yenienserrano yenienserrano linked a pull request Oct 5, 2023 that will close this issue
6 tasks
@Desvelao Desvelao linked a pull request Oct 9, 2023 that will close this issue
6 tasks
@Desvelao
Copy link
Member Author

Desvelao commented Oct 9, 2023

Moved to on hold.

Some problems appear when the page is refreshed due to the application being mounted. We have decided to keep this refresh.

In a meeting, it was decided to remove the refreshing of the page when the application is mounted. Moreover, we want to remove the loading when switching between applications. To do this, we need to refactor how the navigation is done. We must use the methods provided by the platform.

@wazuhci wazuhci moved this from On hold to In progress in Release 4.8.0 Oct 9, 2023
@Desvelao Desvelao linked a pull request Oct 10, 2023 that will close this issue
6 tasks
@wazuhci wazuhci moved this from In progress to Done in Release 4.8.0 Oct 20, 2023
@yenienserrano yenienserrano mentioned this issue Oct 25, 2023
6 tasks
@yenienserrano yenienserrano linked a pull request Oct 25, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment