Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated links from help menu #6368

Closed
3 tasks done
gdiazlo opened this issue Jan 24, 2024 · 3 comments · Fixed by wazuh/wazuh-packages#2796, #6374 or wazuh/wazuh-dashboard#139
Closed
3 tasks done

Remove duplicated links from help menu #6368

gdiazlo opened this issue Jan 24, 2024 · 3 comments · Fixed by wazuh/wazuh-packages#2796, #6374 or wazuh/wazuh-dashboard#139
Assignees
Labels
level/task Task issue type/enhancement Enhancement issue

Comments

@gdiazlo
Copy link
Member

gdiazlo commented Jan 24, 2024

Description

We want to simplify the help menu, because over the years, we've ended duplicating some of the links:

HELP
v4.8.0
Documentation
Community
Give feedback
Open an issue in GitHub
Wazuh support
Documentation
Slack channel
Projects on Github
Google Group

We want to simplify it to:

HELP
v4.8.0
Documentation
Slack channel
Projects on Github
Google Group

The motivation for this changes are:

  • Documentation will remain as it is, pointing users to our extensive documentation library
  • Community is too broad to cover with a single link, so we want to provide links to our most used channels (slack and google groups), there are other channels like reddit and discord which are also popular.
  • We want to link to the GitHub org so interested users can reach the all our open source projects

Tasks

@gdiazlo gdiazlo added type/enhancement Enhancement issue level/task Task issue labels Jan 24, 2024
@wazuhci wazuhci moved this to Backlog in Release 4.8.0 Jan 24, 2024
@wazuhci wazuhci moved this from Backlog to In progress in Release 4.8.0 Jan 24, 2024
@Tostti
Copy link
Member

Tostti commented Jan 24, 2024

Research

The current menu is this
image

The duplication happens because the upper section is from Wazuh Dashboard itself, while the other section is added on the plugin

addHelpMenuToAppChrome();

Moreover, this causes an inconsistency in the menu, because if the user is outside the main Wazuh plugin, the menu will only be the upper section of the previously shown:
image

Proposed solution

The solution should fix the menu and also make it consistent through all the application. To do that, the proposed steps are:

  1. Change the menu in the package building on the wazuh-packages repo.
  2. Remove the added menu in the Wazuh app.

Additionally, considering that in the future the package will be built in the wazuh-dashboard repo, it will be a nice to also apply the changes there.

@Tostti
Copy link
Member

Tostti commented Jan 24, 2024

@wazuhci wazuhci moved this from In progress to Pending review in Release 4.8.0 Jan 29, 2024
@wazuhci wazuhci moved this from Pending review to In progress in Release 4.8.0 Jan 29, 2024
@wazuhci wazuhci moved this from In progress to Pending review in Release 4.8.0 Jan 29, 2024
@Tostti Tostti removed a link to a pull request Jan 30, 2024
8 tasks
@Tostti Tostti linked a pull request Jan 30, 2024 that will close this issue
8 tasks
@wazuhci wazuhci moved this from Pending review to Pending final review in Release 4.8.0 Jan 31, 2024
@Tostti
Copy link
Member

Tostti commented Jan 31, 2024

All tasks successfully completed

@Tostti Tostti closed this as completed Jan 31, 2024
@wazuhci wazuhci moved this from Pending final review to Done in Release 4.8.0 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/enhancement Enhancement issue
Projects
No open projects
Status: Done
2 participants