Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor style issues #6692

Closed
6 tasks done
asteriscos opened this issue May 22, 2024 · 5 comments · Fixed by #6708
Closed
6 tasks done

Minor style issues #6692

asteriscos opened this issue May 22, 2024 · 5 comments · Fixed by #6708
Assignees
Labels
level/task Task issue type/bug Bug issue

Comments

@asteriscos
Copy link
Member

asteriscos commented May 22, 2024

Wazuh Rev Browser
4.9.0 00 Chrome, Firefox, Safari, etc

Description

The goal of this issue is to fix all minor style issues that we detected in the early stages of Wazuh dashboard 4.9.0.

Threat Hunting alerts bottom table doesn't have margin

image

Standardize search bar padding in Events tabs

image

Standardize search bar padding in Vulnerability Detection Inventory tab

image

Standardize search bar padding in Mitre Att@ct Framework tab

image

Standardize search bar padding in Controls tab from PCI DSS, GDPR, HIPAA, NITS and TSC

image

Tasks

  • Threat Hunting alerts bottom table doesn't have margin.
  • Standardize search bar padding in Events tabs.
  • Standardize search bar padding in Vulnerability Detection Inventory tab.
  • Standardize search bar padding in Mitre Att@ct Framework tab.
  • Standardize search bar padding in Controls tab from PCI DSS, GDPR, HIPAA, NITS and TSC.
  • Standardize margins and paddings in Dashboard, Events, Inventory and Control tabs from all modules.
@asteriscos asteriscos added level/task Task issue type/bug Bug issue labels May 22, 2024
@lucianogorza lucianogorza self-assigned this May 22, 2024
@wazuhci wazuhci moved this to In progress in Release 4.9.0 May 22, 2024
@lucianogorza
Copy link
Contributor

lucianogorza commented May 23, 2024

Space comparison

Going through the application modules and the tabs of each module, we find different layouts, which present different spacings between the components.

For example, in the Threat Hunting module, the space between components is 8px in the Dashboard tab, while it is 24px in the Events tab.

Threat Hunting -> Dashboard tab

image

Threat Hunting -> Events tab

image

@lucianogorza
Copy link
Contributor

lucianogorza commented May 23, 2024

Events tab with the same spaces as Dashboard tab

image

@lucianogorza
Copy link
Contributor

lucianogorza commented May 23, 2024

Mitre Att&ct Framework and Intelligence tabs

image

image

@lucianogorza
Copy link
Contributor

Vulnerability Detection Inventory Tab

image

@lucianogorza
Copy link
Contributor

Controls tab from PCI DSS, GDPR, HIPAA, NITS and TSC

image

@lucianogorza lucianogorza linked a pull request May 24, 2024 that will close this issue
6 tasks
@lucianogorza lucianogorza mentioned this issue May 24, 2024
6 tasks
@lucianogorza lucianogorza moved this from In progress to Pending review in Release 4.9.0 May 24, 2024
@wazuhci wazuhci moved this from Pending review to In review in Release 4.9.0 May 27, 2024
@wazuhci wazuhci moved this from In review to Pending final review in Release 4.9.0 May 27, 2024
@wazuhci wazuhci moved this from Pending final review to Done in Release 4.9.0 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/bug Bug issue
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants