Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with OpenSearch 2.18.0 #415

Closed
4 tasks done
asteriscos opened this issue Nov 15, 2024 · 3 comments · Fixed by #416
Closed
4 tasks done

Compatibility with OpenSearch 2.18.0 #415

asteriscos opened this issue Nov 15, 2024 · 3 comments · Fixed by #416
Assignees
Labels

Comments

@asteriscos
Copy link
Member

asteriscos commented Nov 15, 2024

Description

We need to ensure the UI compatibility with the next version of OpenSearch v2.18.0
This update is still being discussed, but we need to be aware of potential issues.

Note

The compatibility for OS 2.18.0 is for Wazuh v5.0.0

For that, we need to:

  • Review opensearch and opensearch-dashboard latest stable changelog.
  • Identify improvements and potential impact on the UI.
  • Create new tracking and development branches.
  • Develop a testing environment to verify our components would work under this new build.

Issues

@wazuhci wazuhci moved this to Backlog in Release 5.0.0 Nov 15, 2024
@asteriscos asteriscos added the request/operational Operational request label Nov 15, 2024
@Desvelao Desvelao self-assigned this Nov 15, 2024
@Desvelao
Copy link
Member

Desvelao commented Nov 15, 2024

Review changelogs

OpenSearch Dashboards 2.18.0

OpenSearch

No relevant changes that could affect to the frontend side at the moment.

@wazuhci wazuhci moved this from Backlog to In progress in Release 5.0.0 Nov 15, 2024
@Desvelao Desvelao linked a pull request Nov 15, 2024 that will close this issue
7 tasks
@Desvelao
Copy link
Member

A pull request was created to add the Wazuh changes to the OpenSearch Dashboards 2.18.0 base tag: #416

@Desvelao
Copy link
Member

Desvelao commented Nov 19, 2024

Theme changes to fix

  • Search bar Dashboard/Events

The changes will be done in the future when creating the new views.
image

Context

In 4.10.x, the search bar uses a EuiPanel with paddingSize='s' https://github.com/wazuh/wazuh-dashboard-plugins/blob/v4.10.0-alpha3/plugins/main/public/components/common/search-bar/search-bar.tsx#L43 but in the development branch for 5.0.0, this has a paddingSize='none' https://github.com/wazuh/wazuh-dashboard-plugins/blob/master/plugins/main/public/components/common/search-bar/search-bar.tsx#L36 that was changed here wazuh/wazuh-dashboard-plugins@a1fc490

The paddingSize='none' was changed to align the search with other elements. This makes sense and we should continue with this change instead of the previous value (s).

The search bar is used in dashboards, events, flyouts that will be redone in the future. We should adapt the render of the search bar taking into account the paddingSize as none.

  • Buttons overlay hidden Dashboards/Events
    image
Context

I deployed OSD 2.18.0 and the problem is present when using the v7theme.
image

Selecting the v9 theme, the problem is not present:
image

  • Change help link

This will be done for 4.10.0 that is missing the changes
image

  • Review help links and labels

This will be done for 4.10.0 that is missing the changes
image

Context

Compare OSD 2.13.0 and Wazuh dashboard 4.9.0, there are changes in text and links: opensearch-project/OpenSearch-Dashboards@2.13.0...wazuh:wazuh-dashboard:v4.9.0
Compare OSD 2.16.0 and Wazuh dashboard 4.10.0, there are less changes: opensearch-project/OpenSearch-Dashboards@2.16.0...wazuh:wazuh-dashboard:4.10.0

See changes in file: src/core/public/chrome/ui/header/header_help_menu.tsx

In 4.10.0, it says Ask Wazuh instead of Slack channel (4.9.0).

In 4.10.0, the Give feedback and Open an issue in GitHub were renamed.

I am not sure about the expected changes to do. I will ask to the team for the context about them.

@wazuhci wazuhci moved this from In progress to Done in Release 5.0.0 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants