Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unchecked return value #48

Closed
vikman90 opened this issue Dec 13, 2023 · 1 comment
Closed

Unchecked return value #48

vikman90 opened this issue Dec 13, 2023 · 1 comment
Assignees
Labels
level/task type/bug Something isn't working

Comments

@vikman90
Copy link
Member

The execute method calls curl_easy_setopt with no error checking:

curl_easy_setopt(m_curlHandle.get(), CURLOPT_HTTPHEADER, m_curlHeaders.get());

@Damian-Mangold
Copy link
Member

Damian-Mangold commented May 7, 2024

@Dwordcito Error code checking was added in a previous implementation

https://github.com/wazuh/wazuh-http-request/blob/main/src/curlWrapper.hpp#L188-L193

so we can close this issue.

@Damian-Mangold Damian-Mangold closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2024
@Damian-Mangold Damian-Mangold reopened this May 7, 2024
@Dwordcito Dwordcito closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants