Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove relative symbolic links #107

Closed
Tracked by #110
AlexRuiz7 opened this issue Jan 8, 2024 · 2 comments · Fixed by #121
Closed
Tracked by #110

Remove relative symbolic links #107

AlexRuiz7 opened this issue Jan 8, 2024 · 2 comments · Fixed by #121
Assignees
Labels
level/task Task issue type/bug Bug issue

Comments

@AlexRuiz7
Copy link
Member

Description

Related issue: #99

The wazuh-indexer@4.9.0 distribution packages include 2 symbolic links that didn't exist on previous wazuh-indexer packages.

/usr/share/wazuh-indexer/data	added
/usr/share/wazuh-indexer/logs	added

Tasks

  • Check if these symbolic links work (not broken).
  • Remove symbolic links during packages assembly.
@AlexRuiz7 AlexRuiz7 added level/task Task issue type/bug Bug issue labels Jan 8, 2024
@f-galland f-galland self-assigned this Jan 12, 2024
@f-galland
Copy link
Member

The symbolic links seem to be valid:

root@pkg-tests-ubuntu2204:~# ls -l /usr/share/wazuh-indexer/{data,logs}
lrwxrwxrwx 1 root root 22 Jan 12 06:52 /usr/share/wazuh-indexer/data -> /var/lib/wazuh-indexer
lrwxrwxrwx 1 root root 22 Jan 12 06:52 /usr/share/wazuh-indexer/logs -> /var/log/wazuh-indexer

@f-galland
Copy link
Member

They are getting created with the packages:

fede@tyner:~/src/wazuh-indexer (107-remove-relative-symbolic-links)$ grep -RE 'ln -s.*(data|logs)'
artifacts/tmp/rpm/wazuh-indexer.rpm.spec:ln -s %{data_dir} %{buildroot}%{product_dir}/data
artifacts/tmp/rpm/wazuh-indexer.rpm.spec:ln -s %{log_dir}  %{buildroot}%{product_dir}/logs
distribution/packages/build/packaging/rpm/wazuh-indexer.rpm.spec:ln -s %{data_dir} %{buildroot}%{product_dir}/data
distribution/packages/build/packaging/rpm/wazuh-indexer.rpm.spec:ln -s %{log_dir}  %{buildroot}%{product_dir}/logs
distribution/packages/build/packaging/deb/debmake_install.sh:ln -s ${data_dir} "${buildroot}${product_dir}/data"
distribution/packages/build/packaging/deb/debmake_install.sh:ln -s ${log_dir} "${buildroot}${product_dir}/logs"
distribution/packages/src/rpm/wazuh-indexer.rpm.spec:ln -s %{data_dir} %{buildroot}%{product_dir}/data
distribution/packages/src/rpm/wazuh-indexer.rpm.spec:ln -s %{log_dir}  %{buildroot}%{product_dir}/logs
distribution/packages/src/deb/debmake_install.sh:ln -s ${data_dir} "${buildroot}${product_dir}/data"
distribution/packages/src/deb/debmake_install.sh:ln -s ${log_dir} "${buildroot}${product_dir}/logs"

@wazuhci wazuhci moved this to In progress in Release 4.9.0 Jan 12, 2024
@f-galland f-galland linked a pull request Jan 12, 2024 that will close this issue
7 tasks
@wazuhci wazuhci moved this from In progress to Pending review in Release 4.9.0 Jan 12, 2024
@wazuhci wazuhci moved this from Pending review to Done in Release 4.9.0 Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/bug Bug issue
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants