Ruleset Files moved to rules/decoders section #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusgn90
reviewed
Mar 12, 2019
| @@ -86,6 +147,21 @@ export class FilesController { | |||
| } | |||
| } | |||
|
|
|||
| addNewFile = type => { | |||
There was a problem hiding this comment.
addNewFile = type => { --> addNewFile(type) {
jesusgn90
reviewed
Mar 12, 2019
| this.$scope.fetchedXML = '<!-- Modify it at your will. -->'; | ||
| this.$scope.type = type; | ||
| this.$scope.cancelSaveAndOverwrite(); | ||
| if (!this.$scope.$$phase) $scope.$digest(); |
There was a problem hiding this comment.
if (!this.$scope.$$phase) $scope.$digest(); --> this.$scope.$applyAsync();
jesusgn90
reviewed
Mar 12, 2019
| this.$location.search('editingFile', true); | ||
| this.appState.setNavigation({ status: true }); | ||
| this.$scope.$emit('fetchedFile', { data: this.$scope.fetchedXML }); | ||
| }; |
|
Other fixes this PR includes:
|
|
Good job @juankaromo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR places files management within its appropriate section (rules or decoders), and change the new file creation place to it.
This PR solves #1298
Regards