Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tabs bars with Tabs component #1705

Merged
merged 5 commits into from
Aug 22, 2019
Merged

Improve tabs bars with Tabs component #1705

merged 5 commits into from
Aug 22, 2019

Conversation

juankaromo
Copy link
Contributor

@juankaromo juankaromo commented Aug 21, 2019

Hi team,

This PR solves #1707 and, in addition, we performed a refactor to replace the old md-nav-bar elements in the dashboards with the new react Tabs component in a dynamic load way, avoiding a lot of conditions checks.

Regards

@juankaromo juankaromo self-assigned this Aug 21, 2019
@juankaromo juankaromo marked this pull request as ready for review August 21, 2019 12:36
@juankaromo juankaromo added type/bug Bug issue type/enhancement Enhancement issue labels Aug 21, 2019
@jesusgn90 jesusgn90 merged commit 4de8c20 into 3.10-7.3 Aug 22, 2019
@jesusgn90 jesusgn90 deleted the refactor-tabs branch August 22, 2019 11:05
jesusgn90 pushed a commit that referenced this pull request Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue type/enhancement Enhancement issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants