Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer access to filter properties #383

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Safer access to filter properties #383

merged 1 commit into from
Apr 18, 2018

Conversation

jesusgn90
Copy link
Contributor

Hello team, this pull request only prevents from weird situations where we are comparing some properties without any validation before accessing the properties.

With this addition we are safer whenever we access them:

...
item.meta && item.meta.params && item.meta.params.query &&
filter.meta && filter.meta.params && filter.meta.params.query &&
...

Best,
Jesús

@jesusgn90 jesusgn90 merged commit bf6bf6b into 3.2 Apr 18, 2018
@jesusgn90 jesusgn90 deleted the 3.2-hotfix-discover branch April 18, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant