Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bugs #442

Merged
merged 1 commit into from
May 10, 2018
Merged

Fix minor bugs #442

merged 1 commit into from
May 10, 2018

Conversation

jesusgn90
Copy link
Contributor

Hello team, this pull request comes to fix the last error described on #427. It only makes little modifications on the data-handler factory. In a brief summary:

  • Ensuring this.end is false while we have more items to show.
  • Put on busy mode at the begin of search method and disable it once done.
  • Also replaces the removeAllFilters logic by an easier one.

Best regards,
Jesús

@havidarou
Copy link
Member

LGTM!

@havidarou havidarou merged commit bcabcd6 into 3.2 May 10, 2018
@havidarou havidarou deleted the 3.2-fix-datahandler branch May 10, 2018 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants