Fix menu positioning problem #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asteriscos
approved these changes
Jan 10, 2023
|
chantal-kelm
requested review from
chantal-kelm
and removed request for
chantal-kelm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the problem with the menu, now it has a fixed position for when the opensearch dashboard header is on or off.
Issues Resolved
Evidence
Test
having enabled and disabled the useExpandedHeader option in the opensearch_dashboards.yml file
Test 1:
Open the menu and it has to be viewed in the correct position.
Test 2:
Scroll and repeat test 1
Test 3:
Repeat test 1 and 2 with the other configuration of the useExpandedHeader setting.
Check List
yarn test:jest