-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed deploy new agent refactor secure connection conditions #5295
Merged
Machi3mfl
merged 5 commits into
4.4-2.4-wzd
from
fix/5283-deploy-new-agent-refactor-secure-connection-conditions
Mar 14, 2023
Merged
Fixed deploy new agent refactor secure connection conditions #5295
Machi3mfl
merged 5 commits into
4.4-2.4-wzd
from
fix/5283-deploy-new-agent-refactor-secure-connection-conditions
Mar 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test casesWhen the connection is
|
|
Test casesLegend:
Windows 2008 and XPConnection Secure - Protocol TCPConnection Secure - Protocol UDPConnection Syslog |
yenienserrano
previously approved these changes
Mar 14, 2023
asteriscos
previously approved these changes
Mar 14, 2023
Machi3mfl
dismissed stale reviews from asteriscos and yenienserrano
via
March 14, 2023 18:04
12274eb
asteriscos
approved these changes
Mar 14, 2023
|
Machi3mfl
deleted the
fix/5283-deploy-new-agent-refactor-secure-connection-conditions
branch
March 14, 2023 18:10
github-actions bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
* Fixed default connection secure param when request fail * Removed unnecessary condtions in code with duplicated code * Fixed warning message in windows xp and 2008 * Fixed style in enrollment message * Updated CHANGELOG (cherry picked from commit 2e5cb9b)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
* Fixed default connection secure param when request fail * Removed unnecessary condtions in code with duplicated code * Fixed warning message in windows xp and 2008 * Fixed style in enrollment message * Updated CHANGELOG (cherry picked from commit 2e5cb9b)
Machi3mfl
added a commit
that referenced
this pull request
Mar 14, 2023
… conditions (#5297) Fixed deploy new agent refactor secure connection conditions (#5295) * Fixed default connection secure param when request fail * Removed unnecessary condtions in code with duplicated code * Fixed warning message in windows xp and 2008 * Fixed style in enrollment message * Updated CHANGELOG (cherry picked from commit 2e5cb9b) Co-authored-by: Maximiliano Ibarra <6089438+Machi3mfl@users.noreply.github.com>
Tostti
pushed a commit
that referenced
this pull request
Mar 14, 2023
… conditions (#5296) Fixed deploy new agent refactor secure connection conditions (#5295) * Fixed default connection secure param when request fail * Removed unnecessary condtions in code with duplicated code * Fixed warning message in windows xp and 2008 * Fixed style in enrollment message * Updated CHANGELOG (cherry picked from commit 2e5cb9b) Co-authored-by: Maximiliano Ibarra <6089438+Machi3mfl@users.noreply.github.com>
5 tasks
AlexRuiz7
pushed a commit
that referenced
this pull request
Mar 17, 2023
* Fixed default connection secure param when request fail * Removed unnecessary condtions in code with duplicated code * Fixed warning message in windows xp and 2008 * Fixed style in enrollment message * Updated CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has refactored code when the connection is secure or not.
Closes #5283
Check List
yarn test:jest