Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change macOS register agent installation command #5484

Merged
merged 5 commits into from
May 24, 2023
Merged

Change macOS register agent installation command #5484

merged 5 commits into from
May 24, 2023

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented May 23, 2023 •
edited
Loading

Description

Hi team,
this PR changes the agent installation command for macOS.

Issues Resolved

Closes #5466

Related to #5481

Evidence

Screenshot from 2023-05-24 12-07-01

Test cases

  • Go to Agents
  • Click on "Deploy new agent"
  • On step 1 select macOS
    • With Password
      • Check the password is shown by default with the correct value
      • Fill in the rest of the configuration and check the double quotes " are escaped \"
      • Check the environment variables are separated by &&
    • Without password
      • When all inputs are empty the echo section of the script should not appear
      • Fill in the rest of the configuration and check the double quotes " are escaped \"
      • Check the environment variables are separated by &&

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this May 23, 2023
@asteriscos asteriscos linked an issue May 23, 2023 that may be closed by this pull request
Agent deploy command for macOS #5466
Closed
This was referenced May 23, 2023
Merged
Merged
@asteriscos asteriscos marked this pull request as ready for review May 24, 2023 10:23
@asteriscos asteriscos requested a review from a team as a code owner May 24, 2023 10:23
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.78% ( 3243 / 36927 )
Branches 4.48% ( 1285 / 28635 )
Functions 7.63% ( 698 / 9147 )
Lines 8.84% ( 3128 / 35361 )

@Machi3mfl Machi3mfl self-requested a review May 24, 2023 15:35
@Machi3mfl
Copy link
Member

Without password

image

With password

image

image

@AlexRuiz7 AlexRuiz7 merged commit 5d63bf7 into 4.4 May 24, 2023
@AlexRuiz7 AlexRuiz7 deleted the fix/5202-register-agent-macos-change-echo-command branch May 24, 2023 15:55
@Machi3mfl Machi3mfl mentioned this pull request Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano left review comments

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@jnasselle jnasselle jnasselle approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent deploy command for macOS
5 participants
@asteriscos @Machi3mfl @jnasselle @yenienserrano @AlexRuiz7