Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance input validation for package generation #1937

Open
jctello opened this issue Nov 20, 2022 · 0 comments
Open

Enhance input validation for package generation #1937

jctello opened this issue Nov 20, 2022 · 0 comments
Labels

Comments

@jctello
Copy link
Contributor

jctello commented Nov 20, 2022

Running package generation with slightly invalid parameters can result in a failed build after a long compilation time.

For example running:

cd wazuh-packages/debs
 ./generate_debian_package.sh -b v4.3.8 -t manager --packages-branch v4.3.8 -a amd64 -s /tmp -r my_rev

after a long time will result in:

dpkg-buildpackage: error: version number contains illegal character `_'
dpkg-buildpackage: source package wazuh-manager
dpkg-buildpackage: source version 4.3.8-my_rev
debuild: fatal error at line 1357:
dpkg-buildpackage -rsudo -D -us -uc -b failed

Luckily running this again with -r myrev will result in a much shorted build time (~10 minutes) since many components are already compiled, but this is time that can be saved by validating that _ is not a valid character for the revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants