Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Wazuh indexer GHA tests #2459

Closed
rauldpm opened this issue Sep 18, 2023 · 1 comment
Closed

Improve Wazuh indexer GHA tests #2459

rauldpm opened this issue Sep 18, 2023 · 1 comment
Labels
level/task Subtask issue type/change Change requested type/enhancement Enhancement issue

Comments

@rauldpm
Copy link
Member

rauldpm commented Sep 18, 2023

Description

It is necessary to analyze and modify the GHA of the Wazuh indexer that checks the SHA of the configuration files in the upgrades since this is not maintainable nor does it take into account accepted changes in said files.

An example would be the following issue #2429, where it is reported that the config.yml file has been modified, which is true since the said file was modified to encapsulate the IPs in double quotes.

It is proposed to replace the test to check the SHA of the files with a functional test where the reliability of the changes is checked. This could be considered in two ways:

  1. Remove the SHA check and add the new test
  2. Keep the SHA check and run the test if a file changes
@rauldpm
Copy link
Member Author

rauldpm commented Sep 18, 2023

Issue closed due: #2429 (comment)

@rauldpm rauldpm closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Subtask issue type/change Change requested type/enhancement Enhancement issue
Projects
None yet
Development

No branches or pull requests

1 participant