Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and fix for the exec resource declarations in wazuh::indexer, wazuh::dashboard and wazuh::filebeat_oss #512

Closed
2 tasks
vaskosmihaylov opened this issue Jun 22, 2022 · 1 comment

Comments

@vaskosmihaylov
Copy link

vaskosmihaylov commented Jun 22, 2022

Description

Classes

Indexer, Dashboard, Filebeat

Behavior

  • Improving the exec resources in the aforementioned classes

Indexer code

Dashboard code

Filebeat related code

The above exec declarations run on every puppet run even though the certificates, folders and configuration are already added:

wazuh-exec

  • Also, the following exec is incorrect:
    path    => '/usr/bin:/bin/',
    command => "echo 'elasticsearch - nofile  65535\nelasticsearch - memlock unlimited' >> /etc/security/limits.conf",
    require => Package[$indexer_package],
  }

It echoes the user elasticsearch in the /etc/security/limits.conf while all the wazuh-indexer directories are owned by wazuh-indexer user and also running on every puppet run it add the line again and again:

grep elasticsearch /etc/security/limits.conf | wc -l
20

Solution

Our team would like to create a PR request, fix and improve the exec declaration and submit a merge request, however before proceeding further we would like to know if this is applicable for the Wazuh team and also if our merge request will be approved.

@vcerenu
Copy link
Member

vcerenu commented Jul 27, 2022

Hello @vaskosmihaylov

We have analyzed and tested the PR that you sent us and it is already merged into the development branch of the current version, so it will be available in the next Wazuh release.

Thank you very much for the development and if you have any questions or ideas, do not hesitate to contact us.

@vcerenu vcerenu closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants