Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Python 3.11 in binary wheels #148

Closed
potiuk opened this issue Oct 26, 2022 · 6 comments
Closed

Support for Python 3.11 in binary wheels #148

potiuk opened this issue Oct 26, 2022 · 6 comments
Assignees
Milestone

Comments

@potiuk
Copy link

potiuk commented Oct 26, 2022

I know it is eaarly (Python 3.11 has just been released yesterday) but we are hoping in Apache Airflow to a much faster cycle of adding new Python releases - especially that Pyhon 3.11 introduces huge performance improvements (25% is the average number claimed) due to a very focused effort to increase single-threaded Python performance (Specialized interpreter being the core of it but also many other improvements) without actually changing any of the Python code.

I'd appreciate if we can have binary releaases for Python 3.11. It's generally not easy to compile Plyvel from scratch so we release it

I just opened such PR in Apache Airflow yesterday and plan to keep it open until it gets green :). So far plyvel had to be excluded there.

apache/airflow#27264

I think it would be fantastic if we could as the open source community migrate to the new Python much faster.

Looking forward to cooperation on that one :)

@wbolster
Copy link
Owner

check out https://pypi.org/project/plyvel/1.5.0/ and https://plyvel.readthedocs.io/en/latest/news.html#plyvel-1-5-0

Rebuild Linux wheels, with manylinux_2_17 and manylinux2014 compatibility (x86_64 only). Also produce Python 3.11 wheels. Still using Snappy 1.1.9 and LevelDB 1.22.

@wbolster wbolster modified the milestones: 1.4.0, 1.5.0 Oct 26, 2022
@wbolster
Copy link
Owner

oh, and if you're wondering why only x86_86, why only manylinux_2_17 and manylinux2014, etc.

i know i know i know 😫 but

f198425

@potiuk
Copy link
Author

potiuk commented Oct 26, 2022

Cool. yeah. We already exclude plyvel from MacOS images/builds. That's not a problem.

@potiuk
Copy link
Author

potiuk commented Oct 26, 2022

Thanks a bunch for quick reaction!

@wbolster
Copy link
Owner

you're welcome.

issues phrased like this one are a million times better than the usual ‘why you no make work on windows and mac 😠’ disregarding the complexity of all that stuff

and this was only a bit of work, so i thought… if not now then when 🙃

@potiuk
Copy link
Author

potiuk commented Oct 31, 2022

Oh yeah. the time is NOW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants