Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour of convert.py script when updating already existing basis file. #11

Open
MJKirk opened this issue Aug 9, 2024 · 1 comment

Comments

@MJKirk
Copy link
Contributor

MJKirk commented Aug 9, 2024

The convert.py script only checks if there is already a corresponding JSON / YAML file, not if they contain the same information.
So if you add operators to an already existing basis, then run the convert script, the changes don't get propogated.

Not huge issue since it's pretty obvious to pick up on in a PR, but I guess ideally there'd be some form of checking the operators in each one to see which is the more/less complete and therefore which form needs regenerating.

@DavidMStraub
Copy link
Collaborator

I'm not sure it's worth reading the existing files and comparing everything. Seems more like a documentation/logging issue to make users aware that they should delete existing files if they want to regenerate the JSONs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants