refs #67773 - test suite love #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmk
requested changes
Jun 14, 2017
andrewdang17
force-pushed
the
67773-test-suite-love
branch
from
b6cacee to
df96374
Compare
|
conflicts resolved |
jamesmk
approved these changes
Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Speed
Individual tests files I changed run faster but when running the entire test suite we maybe saved like 2 seconds...I used
build_stubbedwhich is faster thanbuild/create, combined some feature tests to avoid logging in and revisiting the same route, and dryed up some tests. Not sure what else can be done to speed these tests up (significantly).Test Coverage
Coverage looks pretty good already, ~96% with SimpleCov. The other 4% is just some simple controller tests that I think would be unnecessary to add but I could add them if you want.
Flickering Tests
Didn't come across any