Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media queries overlap #6

Open
venelinn opened this issue May 29, 2019 · 1 comment
Open

Media queries overlap #6

venelinn opened this issue May 29, 2019 · 1 comment

Comments

@venelinn
Copy link

Great plugin !
The only thing I notice is when you use breakpoint.only('m', 'xl') the output should for m should be +1 (769px) ti prevent overlapping.
Example:

@media (min-width: 1201px) { // breakpoint.up('m')
  @content 
} 
@media (min-width: 769px) and (max-width: 1200px) { // breakpoint.only('m', 'xl') 
  @content
} 
@media (max-width: 768px) { // breakpoint.down('m')
  @content
} 

Thanks !

@johnnyBira
Copy link
Contributor

johnnyBira commented Jun 12, 2019

Hi @venelinn!
Thank you for your feedback. I'm glad you found this library useful.
As for you suggestion. I think this would work for your specific senario, however I believe it could cause trouble with other combinations of media queries, creating gaps instead of the overlap you mentioned. Please correct me if I'm wrong as I'd love to see a solution to this problem.

Best,
/John

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants