feat: Add tests for samples

Author: Eric Nijman

README.md

@@ -71,7 +71,7 @@ For now there are 3 commands you can use.
 [cyclejs-usage]: samples/cyclejs/
 [react-favicon-usage]: samples/react-and-favicon/
 [react-graphql-usage]: samples/react-and-graphql/
-[react-sass-usage]: samples/react-and-sass/
+[react-scss-usage]: samples/react-and-scss/
 [root-usage]: samples/
 
 # Dotfile
@@ -135,7 +135,7 @@ module.exports = {
   * [Cyclejs][cyclejs-usage]
   * [React and favicon][react-favicon-usage]
   * [React and graphql][react-graphql-usage]
-  * [React and sass][react-sass-usage]
+  * [React and scss][react-scss-usage]
 
 # Help us
 Support us by giving feedback, opening a pull request or just by starring the project!

getConfig.js

@@ -65,7 +65,7 @@ const resolve = () => ({
   }
 });
 
-const entry = (ent = './src/index.js') => ent;
+const entry = (ent = './src/index.js', cwd = process.cwd()) => path.resolve(cwd, ent);
 
 const optimization = op => op || optimizations();
 
@@ -119,7 +119,7 @@ const getConfig = args => {
   };
 
   const checkOption = checkFile(configFile);
-  logIntro(config);
+  config.env !== 'test' && logIntro(config);
 
   const moduleRules = () => ({
     rules: applyLoaders(config.preset.loaders.map(x => x(config))),

package.json

@@ -75,6 +75,10 @@
     "git-cz": "^1.7.1",
     "jest-cli": "^23.4.2",
     "jest-config": "^23.4.2",
+    "webpacker-cyclejs-sample": "file:./samples/cyclejs",
+    "webpacker-react-and-favicon-sample": "file:./samples/react-and-favicon",
+    "webpacker-react-and-graphql-sample": "file:./samples/react-and-graphql",
+    "webpacker-react-and-scss-sample": "file:./samples/react-and-scss",
     "xyz": "^3.0.0"
   }
 }

samples/cyclejs/package.json

@@ -10,10 +10,9 @@
   },
   "author": "Renan Borges <renan@wearereasonablepeople.com> (https://github.com/renanborgez)",
   "license": "ISC",
-  "devDependencies": {
+  "dependencies": {
     "@cycle/dom": "^20.4.0",
     "@cycle/run": "^4.4.0",
-    "webpacker": "github:wearereasonablepeople/webpacker#master",
     "xstream": "^11.7.0"
   }
 }

samples/react-and-favicon/package.json

@@ -10,7 +10,7 @@
   },
   "author": "Renan Borges <renan@wearereasonablepeople.com> (https://github.com/renanborgez)",
   "license": "ISC",
-  "devDependencies": {
+  "dependencies": {
     "react": "^16.4.1",
     "react-dom": "^16.4.1"
   }

samples/react-and-graphql/package.json

@@ -10,7 +10,7 @@
   },
   "author": "Renan Borges <renan@wearereasonablepeople.com> (https://github.com/renanborgez)",
   "license": "ISC",
-  "devDependencies": {
+  "dependencies": {
     "react": "^16.4.1",
     "react-dom": "^16.4.1"
   }

samples/react-and-sass/.webpacker.js samples/react-and-scss/.webpacker.js

@@ -10,7 +10,7 @@
   },
   "author": "Renan Borges <renan@wearereasonablepeople.com> (https://github.com/renanborgez)",
   "license": "ISC",
-  "devDependencies": {
+  "dependencies": {
     "react": "^16.4.1",
     "react-dom": "^16.4.1"
   }

samples/react-and-sass/package.json samples/react-and-scss/package.json

@@ -0,0 +1,21 @@
+const {runner} = require('./testRunner');
+
+runner({
+  dir: 'cyclejs',
+  name: 'Cyclejs',
+});
+
+runner({
+  dir: 'react-and-favicon',
+  name: 'React and favicon',
+});
+
+runner({
+  dir: 'react-and-graphql',
+  name: 'React and GraphQL',
+});
+
+runner({
+  dir: 'react-and-scss',
+  name: 'React and SCSS',
+});

samples/react-and-sass/src/index.html samples/react-and-scss/src/index.html

@@ -0,0 +1,46 @@
+const path = require('path');
+const webpack = require('webpack');
+const MemoryFS = require('memory-fs');
+const {getConfig} = require('../../getConfig');
+
+const runner = ({dir, name, config}) => {
+  const fs = new MemoryFS();
+
+  const sample = (p = '') => path.join(__dirname, `../../samples/${dir}`, p);
+
+  const build = (args, cb) => {
+    const config = getConfig(args);
+    const compiler = webpack({
+      ...config,
+      entry: path.resolve(args.cwd, './src/index'),
+    });
+
+    compiler.outputFileSystem = fs;
+
+    compiler.run((err, stats) => {
+      if(err) {
+        throw new Error(err);
+      }
+      if(stats.hasErrors()) {
+        throw new Error(stats.toString('errors-only'));
+      }
+      cb();
+    });
+  };
+
+  describe(`${name} sample`, () => {
+    it('should not crash when building for development', done => {
+      build({
+        env: 'test',
+        mode: 'development',
+        cwd: sample(),
+        config: sample('.webpacker.js'),
+        ...config,
+      }, done);
+    });
+  });
+};
+
+module.exports = {
+  runner,
+};