New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also install PHP dependencies #13

Open

ocean90 opened this issue Nov 18, 2020 · 0 comments

Labels

[Package] generate [Package] wordpress-plugin-boilerplate [Type] Enhancement

Member

ocean90 commented Nov 18, 2020

We already install the JS dependencies but not the ones defined in composer.json for PHP.

js/packages/wordpress-plugin-boilerplate/lib/commands/create.js

Lines 238 to 241 in 5792ace

    
           // Install dependencies. 
        
           await runStep( 'Installing dependencies', 'Could not install dependencies.', async () => { 
        
           	await runShellCommand( 'npm install', pluginDir ); 
        
           } );

ocean90 added [Type] Enhancement [Package] wordpress-plugin-boilerplate labels

ocean90 added the [Package] generate label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment