New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate ResponseWriter interception to library #24

Open

philwinder opened this issue Mar 10, 2017 · 0 comments

Contributor

philwinder commented Mar 10, 2017

I read that there are edge cases where intercepting status codes from a response writer can fail:
https://github.com/felixge/httpsnoop#why-this-package-exists

Consider replacing https://github.com/weaveworks/common/blob/master/middleware/instrument.go#L44

With: https://github.com/felixge/httpsnoop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment