Skip to content

Commit

Permalink
Add Waiting canary status phase
Browse files Browse the repository at this point in the history
means the canary rollout is paused (waiting for confirmation to proceed)
  • Loading branch information
stefanprodan committed Jul 24, 2019
1 parent a0a4d4c commit dfdcfed
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions artifacts/flagger/crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ spec:
- ""
- Initializing
- Initialized
- Waiting
- Progressing
- Succeeded
- Failed
Expand Down
1 change: 1 addition & 0 deletions charts/flagger/templates/crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ spec:
- ""
- Initializing
- Initialized
- Waiting
- Progressing
- Succeeded
- Failed
Expand Down
1 change: 1 addition & 0 deletions kustomize/base/flagger/crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ spec:
- ""
- Initializing
- Initialized
- Waiting
- Progressing
- Succeeded
- Failed
Expand Down
2 changes: 2 additions & 0 deletions pkg/apis/flagger/v1alpha3/status.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ const (
// CanaryPhaseInitialized means the primary deployment, hpa and ClusterIP services
// have been created along with the service mesh or ingress objects
CanaryPhaseInitialized CanaryPhase = "Initialized"
// CanaryPhaseWaiting means the canary rollout is paused (waiting for confirmation to proceed)
CanaryPhaseWaiting CanaryPhase = "Waiting"
// CanaryPhaseProgressing means the canary analysis is underway
CanaryPhaseProgressing CanaryPhase = "Progressing"
// CanaryPhaseSucceeded means the canary analysis has been successful
Expand Down
3 changes: 3 additions & 0 deletions pkg/canary/status.go
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,9 @@ func (c *Deployer) MakeStatusConditions(canaryStatus flaggerv1.CanaryStatus,
case flaggerv1.CanaryPhaseInitialized:
status = corev1.ConditionTrue
message = "Deployment initialization completed."
case flaggerv1.CanaryPhaseWaiting:
status = corev1.ConditionUnknown
message = "Waiting for approval."
case flaggerv1.CanaryPhaseProgressing:
status = corev1.ConditionUnknown
message = "New revision detected, starting canary analysis."
Expand Down

0 comments on commit dfdcfed

Please sign in to comment.